Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Original parser fixes #36

Merged
merged 2 commits into from
Aug 3, 2024
Merged

Original parser fixes #36

merged 2 commits into from
Aug 3, 2024

Conversation

bits0rcerer
Copy link
Contributor

This PR fixes:

  • an off by two error in the original parser while parsing HELP and SIZE commands. (I think this should save 2 loop iterations in the parser loop)
  • set last_byte_parsed for the binary PB command

sbernauer
sbernauer approved these changes Aug 3, 2024
View reviewed changes
Copy link
Owner

@sbernauer sbernauer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!
Quickly tested using echo 'SIZEHELPSIZEPX 0 0' | nc 127.0.0.1 1234, seems to respond correctly

@sbernauer sbernauer merged commit d571b1a into sbernauer:main Aug 3, 2024
8 checks passed
sbernauer added a commit that referenced this pull request Aug 3, 2024
@sbernauer
chore: Add missing changelog entry for #36
c8b8757
@bits0rcerer bits0rcerer deleted the original-parser-fixes branch August 13, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbernauer sbernauer sbernauer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bits0rcerer @sbernauer