Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce the usage of new style cost functionals #134

Merged
merged 1 commit into from
Nov 10, 2022

Conversation

sblauth
Copy link
Owner

@sblauth sblauth commented Nov 10, 2022

Also closes #133

@sblauth sblauth added the enhancement New feature or request label Nov 10, 2022
@sblauth sblauth self-assigned this Nov 10, 2022
@sblauth sblauth enabled auto-merge (rebase) November 10, 2022 07:53
@codecov-commenter
Copy link

codecov-commenter commented Nov 10, 2022

Codecov Report

Merging #134 (14422b8) into main (fb86934) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #134      +/-   ##
==========================================
- Coverage   93.75%   93.74%   -0.00%     
==========================================
  Files          65       65              
  Lines        5628     5625       -3     
==========================================
- Hits         5276     5273       -3     
  Misses        352      352              
Impacted Files Coverage Δ
...ization/optimal_control/optimal_control_problem.py 100.00% <ø> (ø)
...n/shape_optimization/shape_optimization_problem.py 96.95% <ø> (ø)
cashocs/space_mapping/optimal_control.py 89.21% <ø> (ø)
cashocs/space_mapping/shape_optimization.py 85.59% <ø> (ø)
cashocs/_constraints/constrained_problems.py 92.86% <100.00%> (ø)
cashocs/_constraints/solvers.py 94.39% <100.00%> (+0.03%) ⬆️
cashocs/_optimization/optimization_problem.py 94.41% <100.00%> (-0.15%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sblauth sblauth merged commit 1e8dc68 into main Nov 10, 2022
@sblauth sblauth deleted the feature/enforce_new_cost_functionals branch November 10, 2022 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] When Scaling, cashocs replaces IntegralFunctional with ufl.Form
2 participants