Added damping for BFGS method #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that the curvature condition is satisfied.
Codecov Report
@@ Coverage Diff @@
## main #158 +/- ##
==========================================
+ Coverage 93.68% 93.73% +0.05%
==========================================
Files 76 76
Lines 5775 5801 +26
==========================================
+ Hits 5410 5437 +27
+ Misses 365 364 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This is now also done in the non-damped case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The damping can be enabled via the config files (it is disabled by default).
The damping ensures that the curvature condition is satisfied, so that a restarting of the method is not necessary.
Closes #35