FEAT: Add support and tests for Python 3.12 #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #324 +/- ##
==========================================
- Coverage 91.29% 91.29% -0.00%
==========================================
Files 86 86
Lines 7517 7516 -1
==========================================
- Hits 6862 6861 -1
Misses 655 655 ☔ View full report in Codecov by Sentry. |
|
It seems as if Python 3.12 is (from the FEniCS side) only supported with PETSc 3.20 - which is at the moment not compatible with cashocs, see #320 In case this incompatibility is resolved, there should be nothing standing in the way of using cashocs with Python 3.12 |
|
See here https://gitlab.com/petsc/petsc/-/merge_requests/6976 for the corresponding issue in PETSc's Gitlab |
Check for global number of vertices and cells instead of local ones for the test.
This is important so that the tests don't fail in parallel.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Python 3.12 for cashocs.
Closes #325