Avoid PETSc segfaults due to DMCollection #468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There, calling transfer_matrix.createVecs() was causing segfaults. However, the matrix could still be used for multiplication, which works just fine The call to createVecs was unnecessary, and thus removed.
Replace calls to `getVec...` with `createVec` for better petsc4py / PETSc match Refactor the way the transfer matrix is used for the global deformation (createVec does not have to be called here)
|
Note: Some tests will fail - this is due to the fact that we merge this onto v2.1.3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PETScDMCollection can still be used with newer versions of PETSc / petsc4py.
However, using
.createVecsor similar cannot be done on the transfer matrix. The matrix can, however, still be multiplied, which is all we need.