Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create custom tooltips #190

Merged
merged 5 commits into from
May 24, 2021
Merged

Create custom tooltips #190

merged 5 commits into from
May 24, 2021

Conversation

IRHM
Copy link
Member

@IRHM IRHM commented May 24, 2021

Changes made

Create custom tooltip that can easily be applied to elements by adding the tooltip attribute to them as such: <button tooltip="click me to click something" />.

Added tooltips to controls in VideoEditor that need more context.

Closes #188

IRHM added 5 commits May 21, 2021 20:28
Positioning of tooltip not working correctly when using it
Still has sort of "laggy" transition when none is applied, which looks better than no scaling i think
Works better with different configurations of buttons inside (that aren't being used, but might be in the future).

Also fixes tooltips position on buttons inside container, since border wasn't being counted in height.
@IRHM IRHM added the enhancement New feature, request or improvement label May 24, 2021
@IRHM IRHM self-assigned this May 24, 2021
@IRHM IRHM merged commit 3084d0e into sbondCo:master May 24, 2021
@IRHM IRHM deleted the tooltip-for-btns branch May 24, 2021 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, request or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Tooltip component for Buttons.
1 participant