Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clips view #200

Merged
merged 11 commits into from
Jul 7, 2021
Merged

Clips view #200

merged 11 commits into from
Jul 7, 2021

Conversation

IRHM
Copy link
Member

@IRHM IRHM commented Jul 7, 2021 •
edited
Loading

Changes made

  • Add section for viewing clips in Videos view (Recordings view => Videos view).
  • Append clip to Clips.json after creating it.
  • Rename PastRecordings.json to Recordings.json.

Closes #197

IRHM added 11 commits July 7, 2021 13:26
@IRHM
Create viewToggler in Recordings view
796a154 
to switch between clips and recordings
@IRHM
Load all clips and recordings once from file, instead of reading file…
781fc9f 
… every switch

Also remove getClips and integrate it into get func with param
@IRHM
Rename PastRecordings.json file to recordings.json
1af49f2 
hope no one notices
@IRHM
Follow file naming scheme and make new files use PascalCase
6a2f92e
@IRHM
Add clip to clips file once done clipping
07e9caf 
Also edit some comments for funcs in recordingsManager and create getVideoFile so we don't have to copy paste and if statement everywhere.
@IRHM
Put wrapper around viewtoggler and thumbs
7571fee 
So viewtoggler is also centered
@IRHM
Fix styling when noRecordings msg is showing
27fe74c
@IRHM
Make messages use activeSubPage where required
31153f5 
Create _general.scss file for general styles
@IRHM
Use margin-left on thumbs to avoid having margin when not needed
6184ade
@IRHM
Increase margin between divs on Recordings
c3760b6
@IRHM
Rename Recordings view to Videos
bca3c7c
@IRHM IRHM added the enhancement New feature, request or improvement label Jul 7, 2021
@IRHM IRHM self-assigned this Jul 7, 2021
@IRHM IRHM merged commit f25b005 into sbondCo:master Jul 7, 2021
@IRHM IRHM deleted the clips-view branch July 7, 2021 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@IRHM IRHM

Labels
enhancement New feature, request or improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create view for users to browse their clips.
1 participant
@IRHM