Refactor #530
Merged
Refactor #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Converted most of the code to standard classes and removed dependencies on service instances (like `Config`). This makes each class much cleaner, and consistent and above all more unit testable on its own. There is a new `Application` class which is a singleton service which provides factory methods for things like `config`, `context`, `deviceList` and all the stuff which happens at run time. This impacted logging which should only be used after deliberate initialisation, but which was being prematurely initialised - so these have had their `require()`s moved inline with method calls where necessary. This also tidies up a lot of unit tests, file names, class names and so on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.