Additional contrast filters #617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbs20
pushed a commit
that referenced
this pull request
Sep 25, 2023
Added a filter to increase contrast. On my printer (a Canon Pixma, fwiw), default scan settings lead to "washed out" images, and increasing the contrast generates better scans. In my case, the `-contrast` imagemagick setting was not that great (even when doubled for more effect). That's why I came up with this half-custom `-level 10%,90%` command. It now works great, at least for B/W text documents. For the sake of completeness, I have added both filters in this MR. Not sure whether you want to provide both to all users, or if you find it confusing, in which case I'll let you choose the one to provide to all your users! I have included translations to languages I know, but I'm not a native German speaker. --------- Co-authored-by: jerome <software@froiss.art>
sbs20
added a commit
that referenced
this pull request
Sep 25, 2023
Added a filter to increase contrast. On my printer (a Canon Pixma, fwiw), default scan settings lead to "washed out" images, and increasing the contrast generates better scans. In my case, the `-contrast` imagemagick setting was not that great (even when doubled for more effect). That's why I came up with this half-custom `-level 10%,90%` command. It now works great, at least for B/W text documents. For the sake of completeness, I have added both filters in this MR. Not sure whether you want to provide both to all users, or if you find it confusing, in which case I'll let you choose the one to provide to all your users! I have included translations to languages I know, but I'm not a native German speaker. --------- Co-authored-by: jerome <software@froiss.art>
sbs20
added a commit
that referenced
this pull request
Sep 25, 2023
Added a filter to increase contrast. On my printer (a Canon Pixma, fwiw), default scan settings lead to "washed out" images, and increasing the contrast generates better scans. In my case, the `-contrast` imagemagick setting was not that great (even when doubled for more effect). That's why I came up with this half-custom `-level 10%,90%` command. It now works great, at least for B/W text documents. For the sake of completeness, I have added both filters in this MR. Not sure whether you want to provide both to all users, or if you find it confusing, in which case I'll let you choose the one to provide to all your users! I have included translations to languages I know, but I'm not a native German speaker. --------- Co-authored-by: jerome <software@froiss.art>
sbs20
added a commit
that referenced
this pull request
Nov 3, 2023
It seems that the filters added in #617 were not stable / reliable. This is most likely due to behavioural inconsistencies between imagemagick. We need to work across versions going back years. That said, I couldn't see that they worked on any default version dating from buster to bookworm.
Merged
sbs20
added a commit
that referenced
this pull request
Nov 3, 2023
It seems that the filters added in #617 were not stable / reliable. This is most likely due to behavioural inconsistencies between imagemagick. We need to work across versions going back years. That said, I couldn't see that they worked on any default version dating from buster to bookworm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a filter to increase contrast.
On my printer (a Canon Pixma, fwiw), default scan settings lead to "washed out" images, and increasing the contrast generates better scans.
In my case, the
-contrastimagemagick setting was not that great (even when doubled for more effect). That's why I came up with this half-custom-level 10%,90%command. It now works great, at least for B/W text documents.For the sake of completeness, I have added both filters in this MR. Not sure whether you want to provide both to all users, or if you find it confusing, in which case I'll let you choose the one to provide to all your users!
I have included translations to languages I know, but I'm not a native German speaker.