Fallback to find credential with a null/blank realm #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ref sbt/sbt#2366 Some repositories like Azure DevOps supposedly changes the realm. If credentials are not found for a particular host + realm combo, it will now fallback to using just host, which is expressed by using null or "" realm.
3rwww1
added a commit
to 3rwww1/sbt
that referenced
this pull request
May 3, 2020
As stated in sbt#5492 and sbt#2366 some artifact hosting services (at least Azure Artifacts, seems to affect GCP as well) do not offer a stable HTTP Auth realm that can be safely set in SBT credentials, hence the need to support null or empty Credentials. The Ivy (publishing) side of the issue was fixed in sbt/ivy#36 As to the resolving side, This commit is only part of the solution as it just prevents an NPE and does not consider if coursier itself will fall back to finding credentials with a null realm that matches the server hostname. Related-to: sbt#5492 Related-to: sbt#2366 Signed-off-by: Erwan Queffelec <erwan.queffelec@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref sbt/sbt#2366
Some repositories like Azure DevOps supposedly changes the realm. If credentials are not found for a particular host + realm combo, it will now fallback to using just host, which is expressed by using null or "" realm.