Drop OkHttp dependency #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ref sbt/sbt#6912 Problem ------- There's apparently a security issue with OkHttp 3.x, which I am not really sure how applicable it is to our usage of OkHttp but it is there. Solution -------- Since most of OkHttp-specic usage within LM is for Apache Ivy downloading, I am going to drop this. Since `sbt.librarymanagement.Http.http` is a public API, I am substituting this with Apache HTTP backed implementation.
oyvindberg
added a commit
to ScalablyTyped/Converter
that referenced
this pull request
Jul 13, 2022
- downstream libraries must now upgrade too - was necessary because of dependency changes in sbt, see sbt/librarymanagement#399
oyvindberg
added a commit
to ScalablyTyped/Converter
that referenced
this pull request
Jul 13, 2022
* copy/paste error * Upgrade to sbt 1.7.1 - downstream libraries must now upgrade too - was necessary because of dependency changes in sbt, see sbt/librarymanagement#399
azolotko
added a commit
to azolotko/sbt-gitlab
that referenced
this pull request
Aug 20, 2022
sbt dropped dependency on okhttp3 in sbt/librarymanagement#399 Closes #43
azolotko
added a commit
to azolotko/sbt-gitlab
that referenced
this pull request
Aug 20, 2022
sbt dropped dependency on okhttp3 in sbt/librarymanagement#399 Closes #43
azolotko
added a commit
to azolotko/sbt-gitlab
that referenced
this pull request
Aug 20, 2022
* Replace GigahorseUrlHandler with a custom GitlabURLHandler sbt dropped dependency on okhttp3 in sbt/librarymanagement#399 Closes #43
This was referenced Sep 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref sbt/sbt#6912
Problem
There's apparently a security issue with OkHttp 3.x,
which I am not really sure how applicable it is to our usage
of OkHttp but it is there.
Solution
Since most of OkHttp-specific usage within LM is for Apache Ivy
downloading, I am going to drop this.
Since
sbt.librarymanagement.Http.httpis a public API,I am substituting this with Apache HTTP backed implementation.