Replace scalafmtOnCompile with CI check

[mdedetrich]

This PR replaces scalafmtOnCompile with a github action that runs scalafmt-native that checks if the entire codebase is formatted. The advantage of this versus using scalafmtOnCompile is it doesn't mess up editors while developing and since it is its own github action check it runs in parallel to the main sbt build (this also means it will even run if the sbt fails to load/compile). The scalafmt-native check also only runs on files that are different to origin/develop and since its running in native the entire github check typically only takes around 5-10 seconds.

Most critically it ensures that the code is actually properly formatted since with the current setup, its still possible to push unformatted code just by simply forgetting to compile before pushing (which is what happened before).

The only thing that needs to be done after this PR is merged is to add Scalafmt / Code is formatted as a github CI status check so that you cannot merge PR's if they are not formatted.

[Friendseeker]

This looks fantastic. I am not too sure about disabling scalafmtOnCompile (I use Intellij and scalafmtOnCompile never caused any issue) but adding a CI job to check formatting is certainly very welcomed.

[Friendseeker]

Just want to confirm, does the new CI job also catch an ill-formatted build.sbt file? If so then the PR LGTM.

[Friendseeker]

Wait looks like there's already a scalafmt check as part of CI. If it does the same thing as the PR, I guess the PR is no longer necessary then.

librarymanagement/.github/workflows/ci.yml

Lines 39 to 43 in 55893d3

	- name: Build and test (1)
	if: ${{ matrix.jobtype == 1 }}
	shell: bash
	run: |
	sbt -v -Dfile.encoding=UTF8 scalafmtCheckAll +test +packagedArtifacts

---

Ehh Github does not have a button to rollback PR approval...

[Friendseeker]

Due to #457 (comment), reserving approval for now.

[mdedetrich]

Wait looks like there's already a scalafmt check as part of CI. If it does the same thing as the PR, I guess the PR is no longer necessary then.

Let me change it, sec

[mdedetrich]

@Friendseeker Done

[Friendseeker]

@Friendseeker Done

Thanks! I am not very familiar with the repo as evidenced by me initially overlooking the existence of 'scalafmtcheckAll'. Probably for the best to let Eugene or other people more experienced with the repo to proceed with the review.

[eed3si9n]

Thanks!