feat: tag assembly task #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a tag for the assembly tasks. This can be used to restrict resource usages.
eed3si9n
approved these changes
Nov 7, 2022
I think it's a good idea to put default limit on 1. |
This to prevent the task to fail due to resource starvation. For instance cpu and to many open files. The issue will most likely occur on multi-module project where we do assembly on more than one project. Setting the default to one will ensure that it will work and can be overridden if needed.
|
I agree that a default limit of 1 can be a good default. Please take a look at a04849b |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a tag for the assembly tasks. This can be used to restrict resource usages.
Why do we need this?
Version 2 of sbt-assembly uses more resources. This is problematic when executing
assemblyon a multi-module project causing different types of errors. I've encountered memory and to many open files issue. Adding a tag gives the user of the plugin the option to restrict concurrent executions withGlobal / concurrentRestrictions += Tags.limit(Assembly.assemblyTag, 1)Things to consider