Misconfigured 'assemblyOutputPath' can be dangerous #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also relates to #216 |
eed3si9n
reviewed
Mar 15, 2024
Co-authored-by: eugene yokota <eed3si9n@gmail.com>
dongjoon-hyun
pushed a commit
to apache/spark
that referenced
this pull request
Oct 15, 2024
### What changes were proposed in this pull request? The pr aims to upgrade `sbt-assembly` from `2.2.0` to `2.3.0` ### Why are the changes needed? - `sbt-assembly`, the full release notes: https://github.com/sbt/sbt-assembly/releases/tag/v2.3.0 - Bug fixed: Fixes assembly not creating parent directories by Roiocam in sbt/sbt-assembly#525 Throws error when a misconfigured assemblyOutputPath is detected by hygt in sbt/sbt-assembly#523 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass GA. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #48409 from panbingkun/SPARK-49922. Authored-by: panbingkun <panbingkun@baidu.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
himadripal
pushed a commit
to himadripal/spark
that referenced
this pull request
Oct 19, 2024
### What changes were proposed in this pull request? The pr aims to upgrade `sbt-assembly` from `2.2.0` to `2.3.0` ### Why are the changes needed? - `sbt-assembly`, the full release notes: https://github.com/sbt/sbt-assembly/releases/tag/v2.3.0 - Bug fixed: Fixes assembly not creating parent directories by Roiocam in sbt/sbt-assembly#525 Throws error when a misconfigured assemblyOutputPath is detected by hygt in sbt/sbt-assembly#523 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass GA. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#48409 from panbingkun/SPARK-49922. Authored-by: panbingkun <panbingkun@baidu.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
In a complete PEBKAC moment I essentially did
which resulted in sawing off the proverbial and also literal branch I was sitting on.
I don't believe this is the behavior anyone would ever intend.
Shootout to IntellIJ IDEA's local history feature.