Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Nexus Repository URL #182

Merged
merged 2 commits into from
Sep 22, 2021
Merged

Update Nexus Repository URL #182

merged 2 commits into from
Sep 22, 2021

Conversation

steinybot
Copy link
Contributor

@steinybot steinybot commented Mar 4, 2021

This only updates the README (as that is as far as I have gotten through the setup).

See #181

Base automatically changed from master to main March 11, 2021 09:46
Copy link
Member

@SethTisue SethTisue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The right URL only changed for new Sonatype accounts — the old URL remains right for existing Sonatype accounts. So this is kind of a sideways change in that it will now be right for a different subset of users.

readme.md Outdated
@@ -67,7 +67,8 @@ It's my GitHub account https://github.com/olafurpg/
If you prefer not to save your actual username and password in GitHub Actions
settings below, generate your user tokens:

- login to https://oss.sonatype.org,
- login to https://s01.
atype.org/,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inadvertent line break?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what happened here. I tried making the changes in the browser so must have hit return by mistake.

@steinybot
Copy link
Contributor Author

The right URL only changed for new Sonatype accounts — the old URL remains right for existing Sonatype accounts. So this is kind of a sideways change in that it will now be right for a different subset of users.

That's true. I was assuming that most people who had a project before Feb and who were going to use this plugin would have already set it up and read the docs. I changed it to include both (except for the FAQ which I went with the newer message).

@olafurpg
Copy link
Member

LGTM 👍 Thank you! I'll make a few tweaks after merging to clarify that the old URL is only for old accounts (not projects).

@olafurpg olafurpg merged commit 8a68f60 into sbt:main Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants