Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update sbt-dynver to 5.0.0 #265

Merged
merged 1 commit into from
Apr 25, 2023
Merged

Update sbt-dynver to 5.0.0 #265

merged 1 commit into from
Apr 25, 2023

Conversation

julienrf
Copy link
Contributor

No description provided.

eed3si9n
eed3si9n approved these changes Apr 25, 2023
View reviewed changes
Copy link
Member

@eed3si9n eed3si9n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @julienrf!

@eed3si9n eed3si9n merged commit e199058 into sbt:main Apr 25, 2023
@mkurz
Copy link
Member

mkurz commented Apr 28, 2023

@eed3si9n I think it would be a good idea to cut a new sbt-ci-release release now?

@julienrf julienrf deleted the patch-1 branch April 28, 2023 07:22
@mkurz
Copy link
Member

mkurz commented Apr 28, 2023

You didn't upgrade in project/plugins.sbt:

sbt-ci-release/project/plugins.sbt

Line 4 in e199058

addSbtPlugin("com.dwijnand" % "sbt-dynver" % "4.1.1")

PR: #266

@mkurz
Copy link
Member

mkurz commented Apr 28, 2023

Please wait with a release I think I ran into a bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eed3si9n eed3si9n eed3si9n approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@julienrf @mkurz @eed3si9n