Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sbt to 1.9.0, migrate to new sbt syntax && Modernize a bit the CI (add ScalaSteward, dependabot and release-drafter) #220

Merged
merged 3 commits into from
Jun 5, 2023

Conversation

guizmaii
Copy link
Contributor

@guizmaii guizmaii commented Jun 4, 2023

Fixes #219

steps:
- uses: actions/checkout@v2.3.4
- uses: olafurpg/setup-scala@v10
Copy link
Contributor Author

@guizmaii guizmaii Jun 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replaced by setup-java as setup-scala is using Jabba, which is not maintained anymore

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setup-java includes caching:
cache: sbt
Then you could remove the rm command, too

@@ -0,0 +1,6 @@
version: 2
updates:
- package-ecosystem: "github-actions"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Helps maintaining Github Actions workflows up-to-date

@guizmaii guizmaii changed the title Update sbt to 1.9.0 (fixes https://github.com/sbt/sbt-jmh/issues/219), migrate to new sbt syntax && Modernize a bit the CI (add ScalaSteward and dependabot to help maintain things up-to-date) Update sbt to 1.9.0, migrate to new sbt syntax && Modernize a bit the CI (add ScalaSteward and dependabot to help maintain things up-to-date) Jun 4, 2023
@guizmaii guizmaii changed the title Update sbt to 1.9.0, migrate to new sbt syntax && Modernize a bit the CI (add ScalaSteward and dependabot to help maintain things up-to-date) Update sbt to 1.9.0, migrate to new sbt syntax && modernize a bit the CI (add ScalaSteward and dependabot to help maintain things up-to-date) Jun 4, 2023
… CI (add ScalaSteward, dependabot and release-drafter)
@guizmaii guizmaii changed the title Update sbt to 1.9.0, migrate to new sbt syntax && modernize a bit the CI (add ScalaSteward and dependabot to help maintain things up-to-date) Update sbt to 1.9.0, migrate to new sbt syntax && Modernize a bit the CI (add ScalaSteward, dependabot and release-drafter) Jun 4, 2023
update_release_draft:
runs-on: ubuntu-20.04
steps:
- uses: release-drafter/release-drafter@v5
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatically maintain a changelog in the Github releases

steps:
- uses: actions/checkout@v2.3.4
- uses: olafurpg/setup-scala@v10
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setup-java includes caching:
cache: sbt
Then you could remove the rm command, too

@@ -0,0 +1,16 @@
name: Scala Steward
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other repos in this organisation are using the public Scala-steward, by adding the repo here: https://github.com/search?q=repo%3AVirtusLab%2Fscala-steward-repos%20sbt%2Fsbt-&type=code

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, it's better to use the Github Actions. It's local to the repo, you have more control to when it's launched, you can launch it manually if needed and the PRs don't come from a fork so they're easier to update if necessary

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@guizmaii
Copy link
Contributor Author

guizmaii commented Jun 5, 2023

@mzuehlke

Then you could remove the rm command, too

Removed

Setup-java includes caching:
cache: sbt

We're already using coursier/cache-action for the cache

@mzuehlke
Copy link

mzuehlke commented Jun 5, 2023

But even that should no longer be needed like here: https://github.com/sbt/sbt-ci-release/blob/main/.github/workflows/ci.yml

@guizmaii
Copy link
Contributor Author

guizmaii commented Jun 5, 2023

@mzuehlke Fixed!

Copy link
Contributor

@johanandren johanandren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks. I'll see about a 0.4.5 release.

@johanandren johanandren merged commit 6edee72 into sbt:main Jun 5, 2023
@guizmaii guizmaii deleted the fix_219 branch June 5, 2023 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade project/build.properties to use SBT 1.9.0
3 participants