-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Duplicated startup script names in universal zip #1016
Comments
Thanks a lot for your detailed bug report. Do you have the time to open a pull request for this? This is the code line responsible for this behavior. I'll guide and help you if you feel unsure if you are up to the task ( which I'm sure you are 😎 ) |
I hope I can look at it on the weekend. Meanwhile, why upper case names mangled like |
* Change startup script name generation This commit tries to lower the chance of generation of multiple scripts with equal names in one archive. Fixes #1016. Additionally, an attempt was made to improve the word splitting for the script names, so, for example "UITest" becomes "ui-test" and not "u-i-test". * Heuristics for disambiguating names: second try * Implement simpler disambiguating heuristics * Fix indentation * Fix for the case of single main class * Drop some beautifying logic * Fix formatting * Add note to the documentation on script name generation * Refactor Universal JavaAppPackaging Factor out common code from `BashStartScriptPlugin` and `BatStartScriptPlugin` * Show warning when script name collision is detected * Fix docs formatting * Fix comments and simplify executable bit logic
When the project contains several main classes with the same name in different packages, universal zip contains multiple startup scripts with the same name inside the
bin/
directory.How to reproduce
sbt 'universal:packageBin'
Expected behaviour
Create differently named startup scripts (for example, prepend their name with package name when clashes occur).
Actual behaviour
The created file contains duplicated file names:
Information
Version information:
sbt: 1.0.0
sbt-native-packager: 1.2.2
build system: Ubuntu 16.04.3 LTS
The text was updated successfully, but these errors were encountered: