Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

custom mainClass not working on Windows #415

Closed
tartakynov opened this issue Nov 19, 2014 · 4 comments
Closed

custom mainClass not working on Windows #415

tartakynov opened this issue Nov 19, 2014 · 4 comments
Labels
feature request windows

Comments

@tartakynov
Copy link
Contributor

I've noticed that custom mainClass which is specified by -main argument works perfectly on my linux environment but fails to work on windows. Pull request #319 which indroduced this feature doesn't contain a patch for bat-template.

Version 0.8.0-M2
@muuki88
Copy link
Contributor

muuki88 commented Dec 13, 2014

If you need this feature please provide a pull request. Windows is not the
main strength of our core maintainers and we are very happy about contributions :)

@tartakynov
Copy link
Contributor Author

Sure, I will be glad to provide a pull request

@muuki88
Copy link
Contributor

muuki88 commented Dec 13, 2014

Awesome! Looking forward to it. If you need any help, don't hesitate to ask.

muuki88 added a commit that referenced this issue Dec 16, 2014
@muuki88
Merge pull request #442 from tartakynov/custom-main-windows
353a11a 
#415 custom mainclass for Windows
@muuki88
Copy link
Contributor

muuki88 commented Dec 16, 2014

FIX with #442

@muuki88 muuki88 closed this as completed Dec 16, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request windows
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@muuki88 @tartakynov