Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker: tag -f is deprecated #818

Closed
ahjohannessen opened this issue Jun 21, 2016 · 2 comments · Fixed by #821
Closed

docker: tag -f is deprecated #818

ahjohannessen opened this issue Jun 21, 2016 · 2 comments · Fixed by #821
Labels
bug docker

Comments

@ahjohannessen
Copy link

As of docker 1.10.1 -f flag on docker tag is deprecated and removed in 1.2.0:

val latestCmd = Seq("docker", "tag", "-f", tag, name)

https://github.com/sbt/sbt-native-packager/blob/master/src/main/scala/com/typesafe/sbt/packager/docker/DockerPlugin.scala#L284

They explain the motivation for removing it as follows:

To make tagging consistent across the various docker commands, the -f flag on the docker tag command is deprecated. It is not longer necessary to specify -f to move a tag from one image to another. Nor will docker generate an error if the -f flag is missing and the specified tag is already in use.

So, can we please remove that usage?
@muuki88
Copy link
Contributor

muuki88 commented Jun 21, 2016

Happy to accept a pull request. Will release ASAP :)

@sgrankin sgrankin mentioned this issue Jun 21, 2016
Merged
@ahjohannessen
Copy link
Author

@muuki88 I think @sgrankin beat me to it 👍

muuki88 pushed a commit that referenced this issue Jun 22, 2016
@sgrankin @muuki88
docker: tag -f is deprecated (#821)
897b904 
fixes #818
@khanetor khanetor mentioned this issue Jul 12, 2016
Closed
maciej pushed a commit to maciej/sbt-native-packager that referenced this issue Jul 12, 2016
@sgrankin @maciej
docker: tag -f is deprecated (sbt#821)
6121fda 
fixes sbt#818
@maciej maciej mentioned this issue Jul 12, 2016
Merged
muuki88 pushed a commit that referenced this issue Jul 12, 2016
@maciej @muuki88
docker: tag -f is deprecated (#821) (#845)
a68c7c3 
fixes #818
This was referenced Jan 29, 2017
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug docker
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docker: tag -f is deprecated
2 participants
@ahjohannessen @muuki88