Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use LABEL instead of MAINTAINER for maintainers #1034

Merged
merged 1 commit into from
Oct 21, 2017
Merged

Use LABEL instead of MAINTAINER for maintainers #1034

merged 1 commit into from
Oct 21, 2017

Conversation

NeQuissimus
Copy link
Contributor

@NeQuissimus NeQuissimus commented Sep 25, 2017 •
edited
Loading

Update Spotify docker-client
Update sbt
Update documentation
Update tests

I ran all the tests except for the sudo one since I don't have sudo set up.

Closes #1033

@NeQuissimus
Use LABEL instead of MAINTAINER for maintainers
68950f1 
Update Spotify docker-client
Update sbt
Update documentation
Update tests
@NeQuissimus NeQuissimus mentioned this pull request Sep 26, 2017
Closed
@muuki88 muuki88 added the docker label Sep 26, 2017
muuki88
muuki88 approved these changes Sep 26, 2017
View reviewed changes
Copy link
Contributor

@muuki88 muuki88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are looking good. I restarted the failed Travis jobs. Sometimes they just time out.

Currently the docker tests are not executed via Travis. As you have adjusted the necessary scripted test I assume you have already run them locally on your machine.

I'll release this as soon as I'm back home (~21.10)

muuki88
muuki88 approved these changes Oct 21, 2017
View reviewed changes
Copy link
Contributor

@muuki88 muuki88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this pull request. It contains a few changes that would have been better in separate pull requests (e.g. upgrading sbt, spotify-client), but it's totally okay in this case.

I try to release this as soon as possible

@muuki88 muuki88 merged commit 7dacdea into sbt:master Oct 21, 2017
@NeQuissimus NeQuissimus deleted the maintainer_label branch October 21, 2017 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muuki88 muuki88 muuki88 approved these changes

Assignees
No one assigned
Labels
docker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NeQuissimus @muuki88