Windows batch script improvements

[dwickern]

I added some functions to the batch script to mirror the bash script. This means you can set extra java args using similar syntax:

batScriptExtraDefines += """call :add_java "-Dconfig.file=%APP_HOME%\conf\production.conf""""
bashScriptExtraDefines += """addJava "-Dconfig.file=${app_home}/../conf/production.conf""""

Previously the batch script used a dynamic environment variable name <APP_NAME>_HOME, which is difficult to use from the sbt build. Now it's called APP_HOME always.

The bat script will still read <APP_NAME>_HOME from the environment for backwards compatibility.

application.ini

The bat script now supports javaOptions in Universal via a generated application.ini file. Fixes #688

The ini file uses the -J syntax, so you can use the same ini file for both bat and bash, or you can have different files by specifying batScriptConfigLocation and/or bashScriptConfigLocation.

The bat script will still read <APP_NAME>_config.txt for backwards compatibility.

[muuki88]

Thanks a lot for your work 😍

I'll review this in depth, when I'm back from my vacation ( ~22.10).

[muuki88]

I had a chance to swiftly look through your additions. Could you add a new test that verifies that the configuration works as expected? Also the documentation should be changed.

[muuki88]

Thanks a lot for this amazing additions to the windows support. Only a small hint in the code ( adding some docs ) otherwise this is good to merge.

Would you be interested in becoming a contributor/maintainer for sbt-native-packager? Especially for the windows part? If you have any interested or a curious what this implies, I'm happy to give you a small introduction. Even if you have only little time this would be a great deal of help :)

[muuki88]

We should add some scaladoc here:

Returns the existing mappings with a generated application.ini if
not already provided by the user.

[dwickern]

Sure I'll help maintain this, although I can't make a big time commitment