Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting chdir to application directory. #105

Merged
merged 2 commits into from
Dec 11, 2013
Merged

Setting chdir to application directory. #105

merged 2 commits into from
Dec 11, 2013

Conversation

muuki88
Copy link
Contributor

@muuki88 muuki88 commented Dec 10, 2013

The execution directory is now the application directory

  • Logs get placed relative to the application directory not to the bin directory
  • RUNNING_PID file gets placed in the application directory not in the bin directory

This makes the behavior consistent to former play versions.

Additions

I will provide another commit in this pull request with the following addition:

  • java_server_application in Debian will created a directory /var/log/<application>
  • java_server_application in Debian will created a symlink /usr/share/<application>/logs to /var/log/<application>

With this, logging will be put in the right place without changing the default play logging configuration.
Furthermore the debian purge mechanism should remove all folders correctly.

@jsuereth
Copy link
Member

LGTM. Thanks again!

jsuereth added a commit that referenced this pull request Dec 11, 2013
Setting chdir to application directory.
@jsuereth jsuereth merged commit 85c0b23 into sbt:master Dec 11, 2013
@muuki88 muuki88 deleted the wip_starting_dir branch December 11, 2013 21:08
@muuki88
Copy link
Contributor Author

muuki88 commented Dec 11, 2013

btw. To configure the packaging with java_server archetype you have to add this

serverLoading in Debian := com.typesafe.sbt.packager.archetypes.ServerLoader.Upstart

daemonUser in Debian := "root"

@jsuereth
Copy link
Member

hmmmmmm. I'd like for java_server to be able to be standalone, with a reasonable default. Should we default server-loading and daemonUser to upstart?

I think upstart should be default since it's default in Ubuntu.

@muuki88
Copy link
Contributor Author

muuki88 commented Dec 11, 2013

Yep, I think this would be a good idea. Will take a look this weekend. (and hopefully updated the readme)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants