[Docker] add dockerEnvVars support #1137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muuki88
requested changes
Jul 12, 2018
There was a problem hiding this comment.
Thanks a lot for your pull request 😍 . The overall code looks pretty good. There are only some minor questions.
The only thing that's missing is the settings documentation. You can add it to the docker.rst format
| @@ -10,7 +10,6 @@ import com.typesafe.sbt.packager.linux.LinuxPlugin.autoImport.{daemonUser, defau | |||
| import com.typesafe.sbt.packager.universal.UniversalPlugin | |||
| import com.typesafe.sbt.packager.universal.UniversalPlugin.autoImport.stage | |||
| import com.typesafe.sbt.SbtNativePackager.Universal | |||
| import com.typesafe.sbt.packager.Compat._ | |||
There was a problem hiding this comment.
I'm not sure if this compiles with sbt 0.13.x
| @@ -61,7 +60,7 @@ object DockerPlugin extends AutoPlugin { | |||
| */ | |||
| val UnixSeparatorChar = '/' | |||
|
|
|||
| override def requires = UniversalPlugin | |||
| override def requires: UniversalPlugin.type = UniversalPlugin | |||
There was a problem hiding this comment.
The more generic type would be Plugins
|
@muuki88 applied your requests and added |
muuki88
approved these changes
Jul 12, 2018
|
Perfectly done pull request 👍 thanks a lot. Will release this ASAP |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added docker environment variables support