Fix generated chown command (#1151)

[mcenkar]

#1151

[muuki88]

Thanks for your pull request 🤗🤩

Can you give a bit more details on what issue this fixes and how you ran into it?

A regression test would be helpful for future changes 😊

[mcenkar]

Hi @muuki88 ,

I tried to put detail into related issue: #1151

Basically we have files with $$ in name, and without single quotes around filename it gets replaced with PID, try on your box:

$ echo $$
3548

I was thinking of writing a test, but there's nothing currently there and it's an inner helper method 😢

  private[debian] def makeChownReplacements(mappings: Seq[LinuxPackageMapping],
                                            streams: TaskStreams): (String, String) = {
    // how to create the chownCmd. TODO maybe configurable?
    def chownCmd(user: String, group: String)(path: String): String =
      s"chown $user:$group '$path'"

[muuki88]

Ah! My bad. I overlooked the #1151 reference.

I was thinking of writing a test, but there's nothing currently there and it's an inner helper method 😢

Most of the stuff is tested via sbt scripted 😄 Take a look at src/sbt-test/debian. You can either add it to an existing test or create new one 👍

[mcenkar]

Thanks for info, I adjusted debian tests 👍 😄

[mcenkar]

@muuki88 Thanks for approving, tests seemed to be stuck so I rebased. Still stuck on previous build though 😢 Any chance to get this out as official release or snapshot tomorrow?

[muuki88]

Looks like we killed Travis 😅 I'm currently testing an automated release from Travis and things got stuck a few times. Probably because the project asks for a lot of build resources.

If the new release process works, I might be able to get something out tomorrow ☺️

[muuki88]

Once more :)

[mcenkar]

@muuki88 Hi, any chance to get this out as a released package/snapshot?

[muuki88]

Release 1.3.7 this morning :)