Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1185 Add MiMa to check binary compatibility #1188

Merged
merged 2 commits into from
Jan 12, 2019
Merged

Fix #1185 Add MiMa to check binary compatibility #1188

merged 2 commits into from
Jan 12, 2019

Conversation

muuki88
Copy link
Contributor

@muuki88 muuki88 commented Jan 11, 2019 •
edited by dwijnand
Loading

Fixes #1185

@muuki88 muuki88 added the project General project issues label Jan 11, 2019
@muuki88 muuki88 requested a review from dwijnand January 11, 2019 13:42
dwijnand
dwijnand approved these changes Jan 11, 2019
View reviewed changes
Copy link
Member

@dwijnand dwijnand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable!

@muuki88 muuki88 merged commit c4ef5aa into master Jan 12, 2019
@muuki88
Copy link
Contributor Author

muuki88 commented Jan 12, 2019

Thanks for taking a look ❤️

@muuki88 muuki88 deleted the sbt-native-packager-1185 branch January 30, 2020 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwijnand dwijnand dwijnand approved these changes

Assignees
No one assigned
Labels
project General project issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@muuki88 @dwijnand