Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use daemonUserUid to opt-out of numeric USER #1200

Merged
merged 2 commits into from
Feb 11, 2019
Merged

Conversation

eed3si9n
Copy link
Member

@eed3si9n eed3si9n commented Feb 8, 2019

Fixes #1198

Numeric USER directive is now controlled using daemonUserUid in Docker, which defaults to Some("1001").

To get back to previous behavior the following can be used:

daemonUserUid in Docker := None
daemonUser in Docker    := "daemon"

Fixes sbt#1198

Numeric USER directive is now controlled using `daemonUserUid in Docker`, which defaults to `Some("1001")`.

To get back to previous behavior the following can be used:

```scala
daemonUserUid in Docker := None
daemonUser in Docker    := "daemon"
```

// opt-out of numeric USER
daemonUserUid in Docker := None
daemonUser in Docker := "daemon"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be demiourgos728 too?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's demiourgos728 by default, but here I am demonstrating that it can be changed back to daemon if someone is using that from base image etc.

@kunalkapoor
Copy link

Thanks for fixing this!

@nafg
Copy link

nafg commented Feb 10, 2019

Isn't UserUid repetive ("user user identity") -- I'd rather daemonUid vs. daemonUser

@nafg
Copy link

nafg commented Feb 10, 2019

Couldn't it be a single setting using Either or something?

@eed3si9n
Copy link
Member Author

The key existed since #449.

|WORKDIR /opt/docker
|COPY --from=stage0 --chown=daemon:root /opt/docker /opt/docker
|COPY --from=stage0 --chown=demiourgos728:root /opt/docker /opt/docker
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any particular reason for this name 😆

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Platonism, dēmiourgos (δημιουργός) meaning craftsman, was an artisan-like figure responsible for creating / maintaining the physical universe. At some point this word got misread by someone around 350AD, got mixed up with 'daimon', and out of thin air became Demogorgon. https://twitter.com/eed3si9n/status/1094012513627394049
728 is 'sbt' spelled using telephone keypad. Hopefully this is unique enough name.

Copy link
Contributor

@muuki88 muuki88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this @eed3si9n ❤️

@muuki88 muuki88 merged commit dc6a7ea into sbt:master Feb 11, 2019
@muuki88 muuki88 added the docker label Feb 11, 2019
@eed3si9n eed3si9n deleted the wip/numeric branch February 11, 2019 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants