-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use daemonUserUid to opt-out of numeric USER #1200
Conversation
Fixes sbt#1198 Numeric USER directive is now controlled using `daemonUserUid in Docker`, which defaults to `Some("1001")`. To get back to previous behavior the following can be used: ```scala daemonUserUid in Docker := None daemonUser in Docker := "daemon" ```
|
||
// opt-out of numeric USER | ||
daemonUserUid in Docker := None | ||
daemonUser in Docker := "daemon" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be demiourgos728 too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's demiourgos728 by default, but here I am demonstrating that it can be changed back to daemon if someone is using that from base image etc.
Thanks for fixing this! |
Isn't UserUid repetive ("user user identity") -- I'd rather daemonUid vs. daemonUser |
Couldn't it be a single setting using Either or something? |
The key existed since #449. |
|WORKDIR /opt/docker | ||
|COPY --from=stage0 --chown=daemon:root /opt/docker /opt/docker | ||
|COPY --from=stage0 --chown=demiourgos728:root /opt/docker /opt/docker |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any particular reason for this name 😆
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In Platonism, dēmiourgos (δημιουργός) meaning craftsman, was an artisan-like figure responsible for creating / maintaining the physical universe. At some point this word got misread by someone around 350AD, got mixed up with 'daimon', and out of thin air became Demogorgon. https://twitter.com/eed3si9n/status/1094012513627394049
728 is 'sbt' spelled using telephone keypad. Hopefully this is unique enough name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking care of this @eed3si9n ❤️
Fixes #1198
Numeric USER directive is now controlled using
daemonUserUid in Docker
, which defaults toSome("1001")
.To get back to previous behavior the following can be used: