Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix error message for jdkpackager when antTaskLib is missing #1222

Merged
merged 1 commit into from
May 9, 2019
Merged

fix error message for jdkpackager when antTaskLib is missing #1222

merged 1 commit into from
May 9, 2019

Conversation

Sciss
Copy link
Contributor

@Sciss Sciss commented May 6, 2019

  • grammar: 'find' -> 'found'
  • settings key requires Option[File] not Option[String]

@Sciss
fix error message for jdkpackager when antTaskLib is missing
53aec3a 
- grammar: 'find' -> 'found'
- settings key requires `Option[File]` not `Option[String]`
@lightbend-cla-validator
Copy link

Hi @Sciss,

Thank you for your contribution! We really value the time you've taken to put this together.

Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:

http://www.lightbend.com/contribute/cla

@muuki88 muuki88 added the documentation Documentation should be extended or updated label May 9, 2019
@muuki88
Copy link
Contributor

muuki88 commented May 9, 2019

Thanks for helping to keep native-packager docs useful and readable 🤗

@muuki88 muuki88 merged commit 35dff15 into sbt:master May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muuki88 muuki88 muuki88 approved these changes

Assignees
No one assigned
Labels
documentation Documentation should be extended or updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Sciss @lightbend-cla-validator @muuki88