Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX #211 and #232. Checking $java_args[@] for memory settings, too. #246

Merged
merged 2 commits into from
May 12, 2014

Conversation

muuki88
Copy link
Contributor

@muuki88 muuki88 commented May 10, 2014

Finally. This was a bit tricky, but should be fixed now. @jsuereth you may want to add this to the sbt-launcher-package project, too.

@kardapoltsev can you review/test please? I just checked with Ubuntu 14.04 and play.

@muuki88
Copy link
Contributor Author

muuki88 commented May 10, 2014

After thinking a bit about this issue, I propose to remove the -mem option. This adds no value, but confusion. -J-Xms512m -J-Xmx512m is understandable for most of the java/scala developers, -mem 512 only for a few.

The bash script will get a bit cleaner and we can focus on memory checks regarding java_args and java_opts, so the java_opts override correctly the java_args if specified. What do you think @jsuereth , @kardapoltsev , @aparkinson ?

@kardapoltsev
Copy link
Member

I'm fully agree with removing -mem option.

kardapoltsev added a commit that referenced this pull request May 12, 2014
FIX #211 and #232. Checking $java_args[@] for memory settings, too.
@kardapoltsev kardapoltsev merged commit 94f8343 into master May 12, 2014
@muuki88 muuki88 deleted the wip/bash-jvm-options branch May 12, 2014 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants