Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation about Play 2 packaging as deb- and rpm-packages #427

Merged
merged 2 commits into from
Dec 5, 2014
Merged

Add documentation about Play 2 packaging as deb- and rpm-packages #427

merged 2 commits into from
Dec 5, 2014

Conversation

artempyanykh
Copy link
Contributor

With this PR I'd like to address issue #378.

Since I'm not a native english speaker I could make some dumb mistakes, so feel free to let me know! And if you feel that something is missing also let me know and I'll try to fix that.

@muuki88 muuki88 added the documentation Documentation should be extended or updated label Dec 2, 2014

It is important to mention that you may have certain difficulties with **Upstart**
service manager (i.e. inability to create necessary folders after system restart),
so it is advised to use **SystemV** service manager instead.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this problem was already fixed in #381 . I would change this section to sound a bit more positive. E.g.

Upstart is not supported by all available operation systems and may not always work as expected (See #381). You can always fallback to the SystemV service manager instead.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That definitely sounds better! I'll make that change.

muuki88 added a commit that referenced this pull request Dec 5, 2014
Add documentation about Play 2 packaging as deb- and rpm-packages
@muuki88 muuki88 merged commit 0fea5fc into sbt:master Dec 5, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation should be extended or updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants