Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing update-latest to work with docker 1.3 and greater #452

Merged
merged 1 commit into from
Jan 6, 2015
Merged

Fixing update-latest to work with docker 1.3 and greater #452

merged 1 commit into from
Jan 6, 2015

Conversation

muuki88
Copy link
Contributor

@muuki88 muuki88 commented Jan 6, 2015

Docker 1.3 and greater don't override a preexisting tag without the -f option.
This may create stale images:

> sbt docker:publishLocal
> docker images
docker-test         0.1.0               f2e7a5bb081e        About a minute ago   720 MB
docker-test         latest              f2e7a5bb081e        About a minute ago   720 MB
dockerfile/java     latest              e5b3ce7f0b79        4 days ago           705.7 MB

> sbt docker:publishLocal
> docker images
docker-test         0.1.0               49299e1e9e14        2 seconds ago        720 MB
docker-test         latest              49299e1e9e14        2 seconds ago        720 MB
<none>              <none>              f2e7a5bb081e        About a minute ago   720 MB
dockerfile/java     latest              e5b3ce7f0b79        4 days ago           705.7 MB

@muuki88 muuki88 added the docker label Jan 6, 2015
muuki88 added a commit that referenced this pull request Jan 6, 2015
@muuki88
Merge pull request #452 from sbt/fix/docker-latest-update
5fdf04c 
Fixing update-latest to work with docker 1.3 and greater
@muuki88 muuki88 merged commit 5fdf04c into master Jan 6, 2015
@muuki88 muuki88 deleted the fix/docker-latest-update branch January 6, 2015 12:27
@muuki88 muuki88 mentioned this pull request Jan 7, 2015
Closed
@muuki88 muuki88 added the 0.8.x label Jan 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
docker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@muuki88