Wip/docker refactoring #486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @return MAINTAINER if defined | ||
| */ | ||
| private final def makeMaintainer(maintainer: String): Option[CmdLike] = | ||
| if (maintainer == null || maintainer.isEmpty) None else Some(Cmd("MAINTAINER", maintainer)) |
There was a problem hiding this comment.
How can maintainer ever be null?
There was a problem hiding this comment.
Too much Java code. Should not be possible
|
LGTM - just one use of null that concerns me. |
muuki88
force-pushed
the
wip/docker-refactoring
branch
from
401f89b
to
816b770
Compare
|
Thanks for taking a look. I removed the critical parts. |
|
LGTM |
|
Would be awesome to have this one merged, so that I could easily be one of your first user of these features. In two words: need it cheers, |
muuki88
force-pushed
the
wip/docker-refactoring
branch
from
816b770
to
5f101ac
Compare
|
Available in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First rework of the docker API according to #453
Reviews appreciated @fiadliel , @huntc , @hseeberger