Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experimental support for formats generated by the JDK 8 javapackager tool. #492

Merged
merged 6 commits into from
Feb 15, 2015

Conversation

metasim
Copy link
Member

@metasim metasim commented Feb 13, 2015

No description provided.

@lightbend-cla-validator

Hi @metasim,

Thank you for your contribution! We really value the time you've taken to put this together.

Before we proceed with reviewing this pull request, please sign the Typesafe Contributors License Agreement:

http://typesafe.com/contribute/cla

@muuki88
Copy link
Contributor

muuki88 commented Feb 13, 2015

Smooth! I had time to test it on my Ubuntu system and it worked perfectly for deb files.
Complaining about rpm, but that's a javapackager issue I guess.

I'll test this on windows as well. It would be awesome if you add the sphinx docs as well.
If you need any help on this, just ping me.

@metasim
Copy link
Member Author

metasim commented Feb 13, 2015

I signed the CLA and put some basic docs in the README.md. I'll try to get to the sphinx docs this weekend, but don't hold your breath. I need to add JVM arguments support for my day job.

@muuki88
Copy link
Contributor

muuki88 commented Feb 14, 2015

So, I took a closer look on windows as well. You are hitting a 'bug', which will be
solved in #487 (chmod cannot be used on windows).

Also the locateJDKPackagerTool() did work on windows, I had to set the
setting with

jdkPackagerTool := Some(file("C:\\Program Files\\Java\\jdk1.8.0_31\\bin\\javapackager.exe"))

the error messages are helpful, but could use some examples.

Having said that. I will try to pull off a release tomorrow and I would
like to get this out in the wild for very-early adopters. If you can
add

  • documentation
  • examples in errors messages

this would be nice, but can be added in another pull request as well.
Some scripted tests would be nice as well, but we create some on the
way.

muuki88 added a commit that referenced this pull request Feb 15, 2015
Experimental support for formats generated by the JDK 8 `javapackager` tool.
@muuki88 muuki88 merged commit b26c8e7 into sbt:master Feb 15, 2015
@metasim
Copy link
Member Author

metasim commented Feb 16, 2015

Can you point me to an example of "examples in error messages"?

I'll look into the windows packager lookup issue (now where'd I put vmware...). Should I create a github issue for it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants