FIX #82 adding the ability to specify jvm options via sbt #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kardapoltsev can you have a look at this if the tests all succeed? |
|
I'll try a bit later. |
|
At the first look seems good. |
This was referenced Mar 12, 2015
muuki88
force-pushed
the
wip/jvmopts-in-build
branch
from
9badb02
to
7bd4ab1
Compare
|
This one is a huge one. I added all things discussed in #473 @dhardy92 , @kardapoltsev , @knshiro can you take a look, if you have time. |
muuki88
force-pushed
the
wip/jvmopts-in-build
branch
2 times, most recently
from
478d519
to
6c4c030
Compare
| Java App | ||
| ~~~~~~~~ | ||
|
|
||
| Create a file ``src/universal/conf/jvmopts`` (gets automatically added to the package mappings) |
There was a problem hiding this comment.
Thejvmopts file is a bit confusing since you changed it to application.ini.
muuki88
force-pushed
the
wip/jvmopts-in-build
branch
from
6082789
to
62362c2
Compare
muuki88
added a commit
that referenced
this pull request
Mar 28, 2015
FIX #82 adding the ability to specify jvm options via sbt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the ability to specify
javaOptionsviabuild.sbt.