Fix duplicate jar name when artifact classifier is used #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow. Cant' beleive I missed that. Thanks for the fix! |
jsuereth
added a commit
that referenced
this pull request
Nov 8, 2013
Fix duplicate jar name when artifact classifier is used
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We ran into a problem where our packaged app's classpath was being generated incorrectly. We have two artifacts with the same coordinates, except one has a classifier. In this case the scriptClasspath ended up having two entries with the same name, but only one ended up in the lib directory (in our case it was the wrong one).
This patch adds the classifier to the jar name if one exists so that all files are packaged.