Fix scoping in RPM plugin for #789

[thetristan]

This change updates the RPM plugin settings so that keys starting with rpm are no longer scoped to the Rpm configuration. This should address #789.

I didn't see a formal testing process documented (though I may have missed it in the docs), so far I've only verified that sbt test and sbt scripted rpm/* are passing (both ran on a VM running centos7).

TODO

• Investigate if additional tests are needed, and if so add them

[muuki88]

Thanks for your pull request. Code LGTM. The is a minimal Contributing.md, which describes how to run the tests. We don't have a"formal test process", as the test-matrix for this project is almost infinite :(

There is a simple test sbt-test/rpm/simple-rpm, which only checks if the rpm has been built. It would be nice to extend this test to check if the spec file contains the correct contents. The sbt-test/rpm/systemd-rpm build.sbt has an example on how to check the spec file.

[muuki88]

@thetristan do you need any help for extending the tests?

[thetristan]

@muuki88 I should be OK. I've been busy with real life kind of things but I'll try to get this change wrapped up this weekend.

[thetristan]

I updated the base test for simple-rpm to check the values for the existing keys in that project. I'll extend the test at some point later today to add coverage for the additional keys that aren't prefixed with rpm*, too.

[muuki88]

I see traces of debugging sbt :D

[muuki88]

looks good so far :)

[thetristan]

OK, I was finally able to add those additional checks. Let me know if you see anything else that should be improved.

[thetristan]

At first glance it looks like the build failure from my last push is unrelated. I rebased my commits to re-trigger the build and will investigate further if it fails again.

[muuki88]

Thanks a lot. Will release this ASAP.

[thetristan]

Sure, you're welcome!