Implemented chown file permissions and user/group creation #84
Conversation
Ticket #62: File Permissions - user isn't set?
|
@muuki88 Please sign the latest Typesafe Contributors License Agreement so that we can review and hopefully merge this Pull Request: |
| ;; | ||
| purge) | ||
| deluser --quiet --system ${{user}} > /dev/null || true | ||
| delgroup --quiet --system ${{group}} > /dev/null || true |
There was a problem hiding this comment.
Are we sure we can delete the group always?
There was a problem hiding this comment.
That's a good point. Actually we don't have any clue about the user/group.
I think we have two options
- We remove this behavior. This will leave traces of the application after purging.
- Make this behavior configurable.
For 2. this would need a setting like
debianRemoveUser := true
debianRemoveGroup := trueand question is: What are the default values.
There was a problem hiding this comment.
hmm.... Well for now maybe we'll just document that it has to be a unique user for this service. That's generally a standard good practice. However, it does mean multiple services that are supposed to have the same user won't quite work. In that case, you want a DEB which adds the user/group, and then depend on that I think. In that case, you're probably directly implementing things.
SO, I'd say how it is now is fine for now.
|
Really smooth PR. Looks great! Just a few minor questions for you and I'll merge if everything is still ok. |
|
Cool. Thanks for the work, again! |
Implemented chown file permissions and user/group creation
Ticket #62: File Permissions - user isn't set?
If tested this on Ubuntu 13.10 and it works smoothly. I added some logging that the user has the chance to know what happend to his/her
postrmandpostinstfiles.