Adding 'dockerBuild{Command, Options}' and renaming 'dockerTag' #854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,8 @@ | |||
| package com.typesafe.sbt.packager.docker | |||
|
|
|||
| case class DockerAlias(registryHost: Option[String], username: Option[String], name: String, tag: Option[String]) { | |||
There was a problem hiding this comment.
A little documentation for this class and the public fields would be helpful.
|
LGTM. @fiadliel do you have any objections? |
* dockerBuildCommand The 'dockerBuildCommand' let users customize the command for building Docker images. The current default is 'docker build [dockerBuildOptions] .'. * dockerBuildOptions Furthermore 'dockerBuildOptions' defines which build options are used. The current default is '--force-rm -t [dockerAlias]' (which is expanded if 'dockerUpdateLatest' is set to 'true'. This results in an execution of 'docker build --force-rm -t [dockerAlias] .' (if 'dockerUpdateLatest' is 'false'). * dockerTag being renamed to dockerAlias The 'dockerTag' setting is renamed to 'dockerAlias' as this better reflects the setting. Docker aliases consist of a registry path, username, name and tag ([REGISTRY_HOST/][USERNAME/]NAME[:TAG]). To not confuse the Docker image tag with this setting (as it takes the full alias name), the setting is renamed.
makubi
force-pushed
the
dockerBuildCommand
branch
from
10575ed
to
2da2601
Compare
|
BTW github releases page, release notes for I think 1.2.0-M5, says "dockerTarget renamed" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'dockerBuildCommand' let users customize the command for building
Docker images.
The current default is 'docker build [dockerBuildOptions] .'.
Furthermore 'dockerBuildOptions' defines which build options are used.
The current default is '--force-rm -t [dockerAlias]' (which is expanded
if 'dockerUpdateLatest' is set to 'true'.
This results in an execution of 'docker build --force-rm -t
[dockerAlias] .' (if 'dockerUpdateLatest' is 'false').
The 'dockerTag' setting is renamed to 'dockerAlias' as this better
reflects the setting. Docker aliases consist of a registry path,
username, name and tag ([REGISTRY_HOST/][USERNAME/]NAME[:TAG]).
To not confuse the Docker image tag with this setting (as it takes the
full alias name), the setting is renamed.