Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed SystemVPlugin override start script behavior for debian #893

Merged
merged 1 commit into from
Oct 11, 2016

Conversation

mitch-seymour
Copy link
Contributor

This update is a follow up to the recent fix for overriding the systemv start script for rpm packaging. This update applies the same fix for debian packaging, and adds a couple of new tests as well.

$ cd /path/to/sbt-native-packager
$ sbt # interactive mode
> scripted debian/override-start-script-systemv # new test
> scripted debian/override-start-script-systemv # new test
> scripted debian/override-start-script-upstart # original test, renamed

…ng, and added additional override tests for debian
Copy link
Contributor

@muuki88 muuki88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fast fix. I won't be able to release this for 3 weeks as I'm out of town ( and no laptop )

@mitch-seymour
Copy link
Contributor Author

No problem @muuki88, enjoy your vacation!

@kardapoltsev kardapoltsev merged commit bbeead2 into sbt:master Oct 11, 2016
@kardapoltsev
Copy link
Member

kardapoltsev commented Oct 11, 2016

Thank you, @mitch-seymour!

@mitch-seymour mitch-seymour deleted the patch-3 branch October 11, 2016 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants