Replace deprecated java Docker container with openjdk (#877) #970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muuki88
approved these changes
Apr 30, 2017
muuki88
reviewed
Apr 30, 2017
| @@ -9,7 +9,7 @@ version := "0.1.0" | |||
| maintainer := "Gary Coady <gary@lyranthe.org>" | |||
|
|
|||
| dockerCommands := Seq( | |||
| Cmd("FROM", "dockerfile/java:latest"), | |||
| Cmd("FROM", "dockerfile/openjdk:latest"), | |||
There was a problem hiding this comment.
Ah, sorry. I saw that afterwards. We need to remove the dockerfile/. I will do so and apply it to master and 1.1.x
There was a problem hiding this comment.
Not sure I'm following, this is just a cherry-pick from master. There shouldn't be anything to apply on master, no?
There was a problem hiding this comment.
I guess at the time of this commit dockerfile/openjdk was still valid. 🍒-picking was the write thing 😊
| @@ -151,7 +151,7 @@ Docker Base Image | |||
|
|
|||
| .. code-block:: scala | |||
|
|
|||
| dockerBaseImage := "dockerfile/java" | |||
| dockerBaseImage := "dockerfile/openjdk" | |||
There was a problem hiding this comment.
Same here. We need to remove the dockerfile/
| @@ -195,7 +195,7 @@ In your sbt console type | |||
| .. code-block:: bash | |||
|
|
|||
| > show dockerCommands | |||
| [info] List(Cmd(FROM,dockerfile/java:latest), Cmd(MAINTAINER,Your Name <y.n@yourcompany.com>), ...) | |||
| [info] List(Cmd(FROM,dockerfile/openjdk:latest), Cmd(MAINTAINER,Your Name <y.n@yourcompany.com>), ...) | |||
| @@ -260,7 +260,7 @@ Now let's start adding some Docker commands. | |||
| import com.typesafe.sbt.packager.docker._ | |||
|
|
|||
| dockerCommands := Seq( | |||
| Cmd("FROM", "dockerfile/java:latest"), | |||
| Cmd("FROM", "dockerfile/openjdk:latest"), | |||
|
Released as 1.1.6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport for 1.1.6