Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preserve executable permissions when creating a tarball #993

Merged
merged 1 commit into from
Jun 2, 2017
Merged

Preserve executable permissions when creating a tarball #993

merged 1 commit into from
Jun 2, 2017

Conversation

Krever
Copy link

@Krever Krever commented Jun 1, 2017

This adresses #695

muuki88
muuki88 approved these changes Jun 2, 2017
View reviewed changes
Copy link
Contributor

@muuki88 muuki88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix. That actually makes a lot of sense. Unfortunately this is hard to test, so we'll keep it as is. I'll have to figure out a way to reasonable test this.

@muuki88 muuki88 merged commit 2e8de40 into sbt:master Jun 2, 2017
@Krever Krever deleted the executable-fix branch June 3, 2017 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muuki88 muuki88 muuki88 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Krever @muuki88