Skip to content
This repository has been archived by the owner on Oct 19, 2018. It is now read-only.

Bump to jawn-parser 0.11.0 #21

Closed
wants to merge 2 commits into from

Conversation

suhasgaddam
Copy link

@lloydmeta
Copy link

This would be nice because it would also subsequently fix things like 47degrees/sbt-org-policies#655 (comment) which causes com-lihaoyi/Ammonite#718.

That said, would it be better to shade the dependencies on jawn ?? @eed3si9n

@ches
Copy link

ches commented Oct 18, 2018

The bincompat problem @lloydmeta linked to causes headaches for me with multiple plugins now, as a user and developer with multiple plugins that cross-build for 0.13.x and 1.x.

I think there have been some discussions elsewhere about shading or classloader dark magic for sbt's dependencies—could any maintainers connect the dots with a reference to current standing/thoughts, that might answer why this PR is left on the vine? @eed3si9n @dwijnand

@eed3si9n
Copy link
Member

@ches Thanks for bringing this to my attention.
This is a dependency of sbt 0.13, so unless it's doing something horribly wrong, I don't think we'd change this at this point. Let's move on to sbt 1.

As per Jawn bincompat, I think it makes sense for sjson-new to shade Jawn, so we don't spill over to plugin ecosystem.
I created an issue here - eed3si9n/sjson-new#100

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants