Remove unnecessary F0, F1 and Maybe #84
Conversation
|
#shipit |
|
Could you have the ripple PRs lined up and validated with Dbuild plz? https://jenkins.scala-sbt.org:8592/job/sbt%20validator/build The parameter screen should look like this https://jenkins.scala-sbt.org:8592/job/sbt%20validator/40/parameters/ |
|
@eed3si9n We need to find a better solution than that. It's sad we're doing this just to emulate monorepo, it creates lots of overhead. On a similar note, I tried to validate the PR but I must be logged in with my the scala sbt account or someone has to give me rights. |
|
Can we ship this @eed3si9n ? |
|
I would love to merge this if there are passing ripple PRs. Otherwise, someone else would end up doing the integration work. |
|
Right, is there any reason why the lightbend validator hasn't run here? |
`F0`, `F1` and `Maybe` have become useless since Java 8 introduced `Supplier`, `Function` and `Optional` in the default Java 8 standard library. Therefore, they are not necessary anymore. This change is required to change some Zinc's and sbt APIs. They are not widely used, so the changes will be small.
jvican
force-pushed
the
remove-f0-f1-maybe
branch
from
eda6b7e
to
18a73db
Compare
Syncs up with sbt/util#84.
Syncs up with sbt/util#84.
Syncs with sbt/zinc#359 and sbt/util#84.
|
I have just finished doing two ripple PRs against sbt/sbt and sbt/zinc to validate this change, but realized that since Zinc hasn't been released yet with the new logging API, the validation is going to fail because my PR to sbt/zinc depends on this new API. Can someone validate these PRs manually? They compile fine locally, except for the compilation failures in the logging API. I would like to get this in. |
|
dbuild has checked the following projects against Scala 2.12:
❌ The result is: FAILED |
Syncs up with sbt/util#84.
Syncs up with sbt/util#84.
Syncs up with sbt/util#84.
Syncs up with sbt/util#84. Rewritten from sbt/zinc@6ef476b
F0,F1andMaybehave become useless since Java 8 introducedSupplier,FunctionandOptionalin the default Java 8 standardlibrary.
Therefore, they are not necessary anymore. This change is required to
change some Zinc's and sbt APIs. They are not widely used, so the
changes will be small.