Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reporter API let users create their own configurable reporters #318

Closed
jvican opened this issue Jun 20, 2017 · 0 comments
Closed

Add reporter API let users create their own configurable reporters #318

jvican opened this issue Jun 20, 2017 · 0 comments

Comments

@jvican
Copy link
Member

jvican commented Jun 20, 2017

The details of this issue are explained in the last comments of #304 (comment), where Stu notified us that some functionality downstream in pants was not possible anymore.

We should add an API for this.

@jvican jvican self-assigned this Jun 20, 2017
jvican added a commit to scalacenter/zinc that referenced this issue Jun 20, 2017
This API is inspired by the sbt backend that implements the whole
machinery for `ManagedLogger` and instantiates `LoggerReporter`.

The provided functionality is to get a default reporter configuration
that customises the default instantiation of the reporter. The
instantiation is provided in the same API.

We use contraband for the default reporter configuration to get the
builder pattern so that users can modify it more easily.
jvican added a commit to scalacenter/zinc that referenced this issue Jun 28, 2017
This API is inspired by the sbt backend that implements the whole
machinery for `ManagedLogger` and instantiates `LoggerReporter`.

The provided functionality is to get a default reporter configuration
that customises the default instantiation of the reporter. The
instantiation is provided in the same API.

We use contraband for the default reporter configuration to get the
builder pattern so that users can modify it more easily.
@jvican jvican added this to the 1.0.0-RC1 milestone Jul 10, 2017
cunei pushed a commit to cunei/zinc that referenced this issue Oct 25, 2017
cunei pushed a commit to cunei/zinc that referenced this issue Oct 25, 2017
This reverts commit 3293819.

This resolves issue sbt#327. The packageBin clean hack will be
replaced with a release script.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant