Feature request: Build and return SourceInfos when incremental compilation fails

[adpi2]

When compilation fails, Zinc throws a xsbti.CompileFailed which contains:

• arguments: Array[String]
• problems: Array[Problem]

Based on the previous analysis and the CompileFailed instance I am trying to build an accurate description of the entire codebase but I am lacking information.

I don't know which of the old problems are still valid. Typically, a warning in a file is not reported again if the file is not recompiled, but I don't know if the file has been recompiled or not.

Ideally, the CompileFailed exception could contain an instance of SourceInfos which would give us the list of problems, the old ones that are still valid and the new ones.

At least, as an alternative, I would like to know which files have been recompiled.

[adpi2]

@Friendseeker Since you closed #1306, should we assume this issue cannot be fixed?

[Friendseeker]

@adpi2 Might want to double check with the Scala 2 compiler folks but I do suspect this problem cannot be fixed. The issue is that the compiler early stops and does not necessarily return a complete list of all problems in the recompiled files.

[adpi2]

Re-reading your comment in #1306 I think it's fine that some errors are not reported. What I need is a complete view of the reported errors so that I don't have to buffer then in the BuildServerReporter in sbt.

It's kind of the consensus already: there are some errors, we fix them, and then some more errors can appear. Everybody seems okay with that.

So I think we should merge #1306

[Friendseeker]

@adpi2 Glad to hear your assessment. I shall work on getting #1306 merged. This is also a great opportunity to get #1309 merged as both require AnalysisCallback3. As long as we can get #1306 and #1309 merged in quick succession we can avoid the need to introduce AnalysisCallback4.

[eed3si9n]

When we bump the AnalysisCallback, we probably want to send PRs to Scala 2.13 and Scala 3 so the Scala teams don't have to figure out what to change.