Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register inheritance relationship for SAM-type lambda #1288

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

Friendseeker
Copy link
Member

During dependency extraction, register inheritance dependency for each SAM-type lambda, by fetching SAM type from tree attachment.

Fixes #830

@Friendseeker
Copy link
Member Author

Friendseeker commented Nov 27, 2023

@SethTisue Since this PR includes compiler bridge changes that will be ported to scala/scala, may I also get a review from you or other maintainers of scala/scala?

@Friendseeker
Copy link
Member Author

Friendseeker commented Dec 2, 2023

@Friendseeker Friendseeker reopened this Dec 4, 2023
Register inheritance for SAM

Ensure MemberRef dependency is registered

As per Dependency.scala, need to ensure invariant that member ref dependency is a superset of inheritance dependency

Address PR feedbacks

Add unit test for local inheritance

Invoke checkRecompilations properly
@eed3si9n eed3si9n merged commit c04cd23 into sbt:develop Dec 7, 2023
7 checks passed
@Friendseeker Friendseeker deleted the sam branch December 7, 2023 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SAM type change causes undercompilation
3 participants