Encode parent trait private members in extraHash
to propagate TraitPrivateMembersModified
across external dependency
#1289
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #662
Cause of the issue
To determine if a class has API change
TraitPrivateMembersModified
,extraHash
, which is a hash of private API of a trait is computed. Direct comparison onextraHash
is used to determine if a trait has private member modified.When we have the following dependency
c.C -> b.B -> a.A
, (c.C
extendsb.B
,b.B
extendsa.A
), for whichc.C, b.B, a.A
belongs to different projects, the dependencies are external, hence whenA
has private member modified, the following happensA
is recompiledB
is recompiled since API ofA
has changeTraitPrivateMembersModified
andB
extendsA
.B
is not changed, henceC
is not recompiled even thoughC
extendsB
.Fix
When we compute
extraHash
for a child trait, use the parent traits'extraHash
. Therefore, when parent has private members modified, childextraHash
would change, hence child would haveTraitPrivateMembersModified
, propagating it.