Do not cache source stamps in InitialStamps
#1319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Delegate to getAllSourceStamps
Friendseeker
force-pushed
the
zinc-683
branch
from
d3ea3e6
to
fcaf3d4
Compare
eed3si9n
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #683
Issue
InitialStampsassumes source files do not change during compilation, yet #683 states that they do in fact change.Fix
Remove the source stamp cache in
InitialStamps.Since
InitialStampsis backed by a cache-backedTimeWrapBinaryStamps(unless the user explicitly overrides it), this should have minimal impact on performance.