Copy bytes directly instead of using scala.reflect.io.Streamable
#1395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eed3si9n
approved these changes
Sep 11, 2024
Oh, I wasn't aware of this. I can't find Scala 3 bridge sources, do you mind sharing the link to them ? |
|
IIRC, Scala 3 rewrote the compiler bridge in Java: https://github.com/scala/scala3/tree/main/sbt-bridge/src With what you know / learned by creating this PR, maybe you can find out if a similar change is needed in Scala 3 as well. |
|
Scala 3 is not using reflect.io API at all, so it should not be affected |
|
👍 thanks. Are you going to submit a forward-port to 2.13? https://github.com/scala/scala/blob/2.13.x/src/sbt-bridge/scala/tools/xsbt/AbstractZincFile.scala |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scala.reflect.io.Streamableis way slower than copying bytes directly. Depending on buildtool implementations ofVirtualFileandFileConverterthe code path may end up running this method which for smaller files (1Kb) is 10x slower and for larger ones (20Kb+) even 20x slower. This can add up for bigger codebases.