Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.x] Run AnalysisFormatBenchmark during CI #1406

Closed
wants to merge 2 commits into from

Conversation

Friendseeker
Copy link
Member

@Friendseeker Friendseeker commented Sep 23, 2024

With this PR

  • AnalysisFormatBenchmark is run automatically during CI similar to other benchmarks.
  • Benchmarks are run against PR target branch instead of hardcoded 1.10.x/develop branch

@Friendseeker Friendseeker marked this pull request as draft September 23, 2024 05:02
@Friendseeker
Copy link
Member Author

I guess things rarely work the first try...

[info] Error wrapping InputStream in GZIPInputStream: java.util.zip.ZipException: Not in GZIP format
[info] 	at sbt.internal.io.ErrorHandling$.translate(ErrorHandling.scala:21)
[info] 	at sbt.io.WrapUsing.open(Using.scala:44)
[info] 	at sbt.io.Using.apply(Using.scala:26)
[info] 	at sbt.internal.inc.consistent.ConsistentFileAnalysisStore$AStore.unsafeGet(ConsistentFileAnalysisStore.scala:105)
[info] 	at xsbt.AnalysisFormatBenchmark.read(AnalysisFormatBenchmark.scala:138)
[info] 	at xsbt.AnalysisFormatBenchmark.readAll$$anonfun$1(AnalysisFormatBenchmark.scala:128)
[info] 	at scala.collection.Iterator$$anon$9.next(Iterator.scala:584)
[info] 	at scala.collection.mutable.Growable.addAll(Growable.scala:62)
[info] 	at scala.collection.mutable.Growable.addAll$(Growable.scala:57)
[info] 	at scala.collection.immutable.MapBuilderImpl.addAll(Map.scala:710)
[info] 	at scala.collection.immutable.Map$.from(Map.scala:661)
[info] 	at scala.collection.IterableOnceOps.toMap(IterableOnce.scala:1462)
[info] 	at scala.collection.IterableOnceOps.toMap$(IterableOnce.scala:1461)
[info] 	at scala.collection.AbstractIterator.toMap(Iterator.scala:1303)
[info] 	at xsbt.AnalysisFormatBenchmark.readAll(AnalysisFormatBenchmark.scala:128)
[info] 	at xsbt.AnalysisFormatBenchmark.setup(AnalysisFormatBenchmark.scala:38)

@Friendseeker
Copy link
Member Author

I guess things rarely work the first try...

Figured out how to fix it. Shall start forward porting after wrapping up #1419.

The reason is that we removed binary analysis format, and hence the zips in test data are now text format analysis and we need to change one line in benchmark code to read the zips properly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant